Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] headers_check.pl: disallow extern's | Date | Sat, 3 Jan 2009 02:40:28 +0100 |
| |
On Saturday 03 January 2009, Mike Frysinger wrote: > On Friday 02 January 2009 19:09:57 Arnd Bergmann wrote: > > On Saturday 03 January 2009, Arjan van de Ven wrote: > > > in addition... what business does the kernel have to provide function > > > prototypes to userspace, other than the system call prototypes? > > > > This is the point I raised in my initial comment: we should warn about > > all of them if possible. Note that the syscalls.h file is not even > > exported. I can't think of a single case where a function protoype > > should be exported from the kernel to user space. > > right, and unless people someone can come up with some magic perl code to > detect function prototypes, i suggest we start adding extern keywords ...
In the presence of /usr/bin/ctags-exuberant, we can use that to find all of these. If it doesn't exist, just don't check or warn about the fact that we might be missing checks.
Arnd <><
| |