lkml.org 
[lkml]   [2009]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] kbuild: Disallow GCC 4.1.0 / 4.1.1

    * Linus Torvalds <torvalds@linux-foundation.org> wrote:

    >
    >
    > On Fri, 2 Jan 2009, Ingo Molnar wrote:
    > >
    > > The gcc3 check for gcc 3.0 and 3.1 can be pushed into gcc3 as well - not
    > > sure whether you fixed that. (i fixed it in the patch i just sent - but i
    > > didnt notice the gcc5 mess in gcc4.h that you fixed)
    >
    > I just dropped it. Gcc 3.0 and 3.1 are so old that we simply don't care.

    we didnt support it for quite some time. If you look at that ugly version
    check you replaced:

    #if __GNUC__ >= 4 && !gcc41_inlining_bug
    # include <linux/compiler-gcc4.h>
    #elif __GNUC__ == 3 && __GNUC_MINOR__ >= 2
    # include <linux/compiler-gcc3.h>
    #else
    # error Sorry, your compiler is too old, too buggy or not recognized.
    #endif

    it has a hidden 'gcc 3.0 / 3.1 is not supported' condition in it. So what
    i tried to point out that your patch causes a regression here - we dont
    filter out gcc 3.0/3.1 out anymore.

    Ingo


    \
     
     \ /
      Last update: 2009-01-02 19:05    [W:4.002 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site