Messages in this thread Patch in this message | | | From | "Duane Griffin" <> | Date | Fri, 2 Jan 2009 14:17:17 +0000 | Subject | Re: [PATCH 4/4] ufs: copy symlink data into the correct union member |
| |
On Thu, Jan 01, 2009 at 02:36:20AM +0000, Al Viro wrote: > On Wed, Dec 31, 2008 at 04:50:08PM +0000, Duane Griffin wrote: > > Copy symlink data into the union member it is accessed through. Although > > this shouldn't make a difference to behaviour it makes the code easier > > to follow and grep through. It may also prevent problems if the > > struct/union definitions change in the future. > > > > Signed-off-by: Duane Griffin <duaneg@dghda.com> > > --- > > fs/ufs/namei.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/fs/ufs/namei.c b/fs/ufs/namei.c > > index e3a9b1f..3884730 100644 > > --- a/fs/ufs/namei.c > > +++ b/fs/ufs/namei.c > > @@ -147,7 +147,7 @@ static int ufs_symlink (struct inode * dir, struct dentry * dentry, > > } else { > > /* fast symlink */ > > inode->i_op = &ufs_fast_symlink_inode_operations; > > - memcpy((char*)&UFS_I(inode)->i_u1.i_data,symname,l); > > + memcpy((char *) &UFS_I(inode)->i_u1.i_symlink, symname, l); > > Just what are these cast and & doing there? i_symlink is an array of u8, > for fsck sake; taking its address is a pointless obfuscation. And memcpy() > is just as fine with u8 * as it is with char *...
Ahem. Good points. I neglected to clean-up properly, sorry. Will redo and resend once we've got agreement on the other issues.
Cheers, Duane.
-- "I never could learn to drink that blood and call it wine" - Bob Dylan
| |