Messages in this thread Patch in this message | | | From | (Ingo Brueckl) | Date | Fri, 02 Jan 2009 14:42:00 +0100 | Subject | [PATCH] compile time warnings |
| |
Ingo Molnar <mingo@elte.hu> writes:
> yes, with a small nit: >> >> +static inline void permanent_kmaps_init(pgd_t *pgd_base) >> +{ >> + (void) pgd_base;
> there's no need for this line - this is not a macro, so the function > parameter does not have to be 'used'.
I live and learn.
fix compiler warning in arch/x86/mm/init_32.c
Signed-off-by: Ingo Brueckl <ib@wupperonline.de>
--- linux-2.6.28/arch/x86/mm/init_32.c.orig 2008-12-25 00:26:37.000000000 +0100 +++ linux-2.6.28/arch/x86/mm/init_32.c 2009-01-02 14:21:18.000000000 +0100 @@ -436,8 +436,12 @@ static void __init set_highmem_pages_ini #endif /* !CONFIG_NUMA */
#else -# define permanent_kmaps_init(pgd_base) do { } while (0) -# define set_highmem_pages_init() do { } while (0) +static inline void permanent_kmaps_init(pgd_t *pgd_base) +{ +} +static inline void set_highmem_pages_init(void) +{ +} #endif /* CONFIG_HIGHMEM */
void __init native_pagetable_setup_start(pgd_t *base)
| |