lkml.org 
[lkml]   [2009]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/17] x86-64: Convert irqstacks to per-cpu
Hello,

Brian Gerst wrote:
>> Also, as pda field name, irqstackptr might be fine but wouldn't it be
>> better to rename it to at least irq_stack_ptr as this change requires
>> touching every users anyway?
>
> I kept the same name unless it would conflict with something. If you
> want to rename it, it should be a separate patch.

Sure, that's an option too but it might as well be done when making
those percpu variables. I don't really see why those two changes
should be separate. There isn't any reason why they shouldn't be
separate either but if you're already mucking around every user...

Thanks.

--
tejun


\
 
 \ /
  Last update: 2009-01-18 06:11    [W:0.152 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site