lkml.org 
[lkml]   [2009]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH] ricoh_mmc: Use suspend_late/resume_early
    From
    If ricoh_mmc suspends before sdhci_pci, it will pull the card
    out from under the controller, which could leave the system in
    a very confused state.

    Using suspend_late/resume_early ensures that sdhci_pci suspends first
    and resumes second.

    Signed-off-by: Philip Langdale <philipl@overt.org>
    ---

    ricoh_mmc.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/mmc/host/ricoh_mmc.c b/drivers/mmc/host/ricoh_mmc.c
    index be9e7b3..f627905 100644
    --- a/drivers/mmc/host/ricoh_mmc.c
    +++ b/drivers/mmc/host/ricoh_mmc.c
    @@ -196,7 +196,7 @@ static void __devexit ricoh_mmc_remove(struct pci_dev *pdev)
    pci_set_drvdata(pdev, NULL);
    }

    -static int ricoh_mmc_suspend(struct pci_dev *pdev, pm_message_t state)
    +static int ricoh_mmc_suspend_late(struct pci_dev *pdev, pm_message_t state)
    {
    struct pci_dev *fw_dev = NULL;

    @@ -210,7 +210,7 @@ static int ricoh_mmc_suspend(struct pci_dev *pdev, pm_message_t state)
    return 0;
    }

    -static int ricoh_mmc_resume(struct pci_dev *pdev)
    +static int ricoh_mmc_resume_early(struct pci_dev *pdev)
    {
    struct pci_dev *fw_dev = NULL;

    @@ -229,8 +229,8 @@ static struct pci_driver ricoh_mmc_driver = {
    .id_table = pci_ids,
    .probe = ricoh_mmc_probe,
    .remove = __devexit_p(ricoh_mmc_remove),
    - .suspend = ricoh_mmc_suspend,
    - .resume = ricoh_mmc_resume,
    + .suspend_late = ricoh_mmc_suspend_late,
    + .resume_early = ricoh_mmc_resume_early,
    };

    /*****************************************************************************\
    Based on comments from Rafael, I'm resending this patch using suspend_late and
    resume_early instead.



    \
     
     \ /
      Last update: 2009-01-18 20:11    [W:0.026 / U:2.012 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site