lkml.org 
[lkml]   [2009]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 05/17] x86-64: Move cpu number from PDA to per-cpu and consolidate with 32-bit.
From
On Sun, Jan 18, 2009 at 12:59 AM, Tejun Heo <tj@kernel.org> wrote:
> Brian Gerst wrote:
>> On Sun, Jan 18, 2009 at 12:05 AM, Tejun Heo <tj@kernel.org> wrote:
>>> Hello,
>>>
>>>> --- a/arch/x86/kernel/setup_percpu.c
>>>> +++ b/arch/x86/kernel/setup_percpu.c
>>>> @@ -147,6 +147,9 @@ unsigned long __per_cpu_offset[NR_CPUS] __read_mostly;
>>>> #endif
>>>> EXPORT_SYMBOL(__per_cpu_offset);
>>>>
>>>> +DEFINE_PER_CPU(int, cpu_number);
>>>> +EXPORT_PER_CPU_SYMBOL(cpu_number);
>>> This is inside CONFIG_HAVE_SETUP_PER_CPU_AREA. I think voyage would
>>> be unhappy with this change.
>>
>> Is there any specific reason Voyager doesn't use the x86
>> setup_per_cpu_areas() function? I don't see anything on a quick
>> glance that would not work. The x86 code is pretty much a superset of
>> the default code in init/main.c.
>
> I have no idea at all. Given that not many people can test it, I
> figured just leaving it alone would be the best course but if it can
> be merged, all the better.

Unfortunately Voyager doesn't compile currently for unrelated reasons.
I'll take a look at incorporating it into these patches, but I can't
even do a compile test right now.

--
Brian Gerst


\
 
 \ /
  Last update: 2009-01-18 07:53    [W:0.050 / U:2.660 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site