Messages in this thread | | | Subject | Re: [PATCH] Allow SysRq emergency sync to thaw frozen filesystems | From | Dave Kleikamp <> | Date | Fri, 16 Jan 2009 10:21:47 -0600 |
| |
On Thu, 2009-01-15 at 21:49 -0600, Eric Sandeen wrote: > Andrew Morton wrote: > > On Wed, 14 Jan 2009 22:06:17 -0600 > > Eric Sandeen <sandeen@redhat.com> wrote:
> >> Index: linux-2.6/drivers/char/sysrq.c > >> =================================================================== > >> --- linux-2.6.orig/drivers/char/sysrq.c > >> +++ linux-2.6/drivers/char/sysrq.c > >> @@ -151,6 +151,7 @@ static struct sysrq_key_op sysrq_reboot_ > >> > >> static void sysrq_handle_sync(int key, struct tty_struct *tty) > >> { > >> + emergency_thaw(); > >> emergency_sync(); > >> } > > > > Kind of weird. The thaw will happen after/during the sync(). > > oh, hrm. Maybe I didn't think enough about how it's handed off to > pdflush; I could rearrange if that makes sense? Or maybe handing to > pdflush is wrong, it was just so convenient....
I don't understand the reason for handing it to pdflush. I would expect thaw to be very fast. Do we expect it to block anywhere, and if so, for very long? Not that I see any problem with it.
Shaggy -- David Kleikamp IBM Linux Technology Center
| |