lkml.org 
[lkml]   [2009]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86: avoid early crash in disable_local_APIC()

    * Jan Beulich <jbeulich@novell.com> wrote:

    > >>> Ingo Molnar <mingo@elte.hu> 15.01.09 23:47 >>>
    > >
    > >* Ingo Molnar <mingo@elte.hu> wrote:
    > >
    > >> hm, this gives a build failure on latest -tip:
    > >>
    > >> arch/x86/kernel/apic.c: In function 'setup_local_APIC':
    > >> arch/x86/kernel/apic.c:1135: error: implicit declaration of function 'disable_ioapic_setup'
    >
    > Is this with a config that has X86_IO_APIC off (i.e. one the practical
    > use of which I never understood, and hence easily forget to consider)?
    > Otherwise I can't see how that could happen.

    yeah. Such build failures are reminders to define such functions in a
    .config-invariant way: i.e. an extern prototype plus an inline NOP-wrapper
    for the !IO_APIC case.

    Ingo


    \
     
     \ /
      Last update: 2009-01-16 14:13    [W:0.022 / U:60.948 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site