lkml.org 
[lkml]   [2009]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: 2.6.28-rc9 panics with crashkernel=256M while booting
Date
On Thursday 15 January 2009 13:35:27 Chandru wrote:
> Hello Dave, From the debug console output, if there is anything you can add
> here, pls let me know.

As we can see from the console output here, physbase isn't page aligned when
the panic occurs. So we could as well send (start_pfn << PAGE_SHIFT) to
reserve_bootmem_node() instead of physbase. your thoughts ?.

Also end_pfn in mark_reserved_region_for_nid() is defined as

unsigned long end_pfn = ((physbase + size) >> PAGE_SHIFT);

Does this refer to the pfn after the area that we are interested in ?. We have
atleast two fixes here,
1. Limit start and end to bdata->node_min_pfn and bdata->node_low_pfn in
reserve_bootmem_node() and add comments out in there that the caller of the
funtion should be aware of how much are they reserving.
2. send (start_pfn << PAGE_SHIFT) to reserve_bootmem_node() instead of
physbase.

Chandru


\
 
 \ /
  Last update: 2009-01-16 13:39    [W:0.083 / U:1.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site