lkml.org 
[lkml]   [2009]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] percpu: add optimized generic percpu accessors

* Herbert Xu <herbert@gondor.apana.org.au> wrote:

> Ingo Molnar <mingo@elte.hu> wrote:
> >
> >> Of course. But do any architectures actually _need_ that for a single
> >> read?
> >
> > not for a read i guess - but for the other ops like add/and/or/xor.
>
> One of the things I'd like to see happen with this work is for us to
> have a cheap per-cpu atomic counter that we can use for SNMP stats.
>
> If we can make the inc/add variants into a single instruction, then it
> won't need to disable preemption or interrupts.
>
> So if you could design the API such that we have a variant of add/inc
> that automatically disables/enables preemption then we can optimise that
> away on x86.

Yeah. percpu_add(var, 1) does exactly that on x86.

Ingo


\
 
 \ /
  Last update: 2009-01-16 01:19    [W:0.163 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site