Messages in this thread Patch in this message | | | Date | Thu, 15 Jan 2009 09:30:01 -0800 | From | Mike Travis <> | Subject | Re: crash: IP: [<ffffffff80478092>] __bitmap_intersects+0x48/0x73 [PATCH supplied] |
| |
Ingo Molnar wrote: > FYI, there's new warnings due to cpumask changes: > > arch/x86/kernel/cpu/intel_cacheinfo.c: In function ‘show_cache_disable’: > arch/x86/kernel/cpu/intel_cacheinfo.c:710: warning: unused variable ‘mask’ > arch/x86/kernel/cpu/intel_cacheinfo.c: In function ‘store_cache_disable’: > arch/x86/kernel/cpu/intel_cacheinfo.c:745: warning: unused variable ‘mask’ > > on 32-bit defconfig. > > Ingo
Hi Ingo,
You can pull the following patch to fix this build warning.
Thanks! Mike ---
The following changes since commit e46d51787e23a607cac5f593ac9926743a636dff: Ingo Molnar (1): Merge branch 'master' of ssh://master.kernel.org/.../travis/linux-2.6-cpus4096-for-ingo into cpus4096
are available in the git repository at:
ssh://master.kernel.org/pub/scm/linux/kernel/git/travis/linux-2.6-cpus4096-for-ingo master
Mike Travis (1): x86: fix build warning when CONFIG_NUMA not defined.
arch/x86/include/asm/topology.h | 17 ++++++++++++++--- 1 files changed, 14 insertions(+), 3 deletions(-)
commit f2a082711905312dc7b6675e913fee0c4689f7ae Author: Mike Travis <travis@sgi.com> Date: Thu Jan 15 09:19:32 2009 -0800
x86: fix build warning when CONFIG_NUMA not defined. Impact: fix build warning The macro cpu_to_node did not reference it's argument, and instead simply returned a 0. This causes a "unused variable" warning if it's the only reference in a function (show_cache_disable). Replace it with the more correct inline function. Signed-off-by: Mike Travis <travis@sgi.com>
diff --git a/arch/x86/include/asm/topology.h b/arch/x86/include/asm/topology.h index 4e2f2e0..d0c68e2 100644 --- a/arch/x86/include/asm/topology.h +++ b/arch/x86/include/asm/topology.h @@ -192,9 +192,20 @@ extern int __node_distance(int, int); #else /* !CONFIG_NUMA */ -#define numa_node_id() 0 -#define cpu_to_node(cpu) 0 -#define early_cpu_to_node(cpu) 0 +static inline int numa_node_id(void) +{ + return 0; +} + +static inline int cpu_to_node(int cpu) +{ + return 0; +} + +static inline int early_cpu_to_node(int cpu) +{ + return 0; +} static inline const cpumask_t *cpumask_of_node(int node) { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |