Messages in this thread | | | Date | Thu, 15 Jan 2009 11:14:13 +0000 | From | Jonathan Cameron <> | Subject | Re: [PATCH 2.6.29-rc1-git4] mfd: da9030 usb charge pump support within mfd driver. |
| |
Mike Rapoport wrote: > Jonathan, > Below are my two cents :) Thanks. > Jonathan Cameron wrote: >> From: Jonathan Cameron <jic23@cam.ac.uk> >> >> Add support for changing the mode of the da9030 usb charge pump >> >> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> >> >> --- >> >> Minor changes from previous version to reflect changes in the >> driver being patched. Addtional cc's as per Mark's suggestion. >> >> This version simply adds the functionality to the da903x mfd driver >> core. If anyone can suggest a way round simply maintaining a >> global pointer to the device it would be good. > > I don't think the global pointer here is real problem. It should be *really* > weird design with two da903x. Would be 'unusual'!
>> To be able to call this from a board config file the driver must be >> built in rather than a module but enforcing that is down to the >> board Kconfig entry. > > Most probably the board with da9030 will anyway have it built-in... Agreed. >> +EXPORT_SYMBOL_GPL(da9030_set_usb_charge_pump_mode); >> + > > Maybe we want to have 'da9030_set_usb_charge_pump_mode' as well? (get?) Possibly, though only purpose I can think of for this would be debugging and from the datasheet I can't see any case under which the set can fail?
| |