lkml.org 
[lkml]   [2009]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: CONFIG_MFD_PCF50633=m breaks the kernel build
    On Thu, Jan 15, 2009 at 11:09:55AM +0100, Jean Delvare wrote:
    > On Thu, 15 Jan 2009 14:41:08 +0530, Balaji Rao wrote:
    > > On Thu, Jan 15, 2009 at 10:06:53AM +0100, Jean Delvare wrote:
    > > > Hi Balaji,
    > > >
    > > > Building kernel 2.6.29-rc1-git4 on x86_64 with CONFIG_MFD_PCF50633=m
    > > > fails at linking time with:
    > > >
    > > > ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
    > > > ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!
    > >
    > > Yes, I've seen this. The fix is waiting on linux-mfd to be pulled
    > > anytime soon.
    >
    > Where is linux-mfd? And what is it, a git tree, a mailing list? I
    > couldn't find any reference.

    It's a git tree at http://git.o-hand.com/cgit.cgi/linux-mfd/

    >
    > Can you please send me the patch now, so that I can fix my build
    > locally right now?
    >

    pcf50633: Remove references to non-exported functions

    Remove references to set_irq_type and handle_level_irq which are not
    exported to modules.

    Signed-off-by: Balaji Rao <balajirrao@openmoko.org>

    diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
    index 24508e2..ea9488e 100644
    --- a/drivers/mfd/pcf50633-core.c
    +++ b/drivers/mfd/pcf50633-core.c
    @@ -626,7 +626,6 @@ static int __devinit pcf50633_probe(struct i2c_client *client,
    }

    if (client->irq) {
    - set_irq_handler(client->irq, handle_level_irq);
    ret = request_irq(client->irq, pcf50633_irq,
    IRQF_TRIGGER_LOW, "pcf50633", pcf);


    \
     
     \ /
      Last update: 2009-01-15 11:35    [W:0.032 / U:30.848 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site