lkml.org 
[lkml]   [2009]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] tracing/ftrace: add missing unlock in register_stat_tracer()

    Ingo,

    The following patch is in:

    git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git

    branch: tip/devel


    Li Zefan (1):
    tracing/ftrace: add missing unlock in register_stat_tracer()

    ----
    kernel/trace/trace_stat.c | 4 +++-
    1 files changed, 3 insertions(+), 1 deletions(-)
    ---------------------------
    commit 6af81ac4701bf80dde4b723f28a777daefdf512c
    Author: Li Zefan <lizf@cn.fujitsu.com>
    Date: Thu Jan 15 09:30:52 2009 +0800

    tracing/ftrace: add missing unlock in register_stat_tracer()

    We should unlock all_stat_sessions_mutex before returning failure.

    Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    Signed-off-by: Steven Rostedt <srostedt@redhat.com>

    diff --git a/kernel/trace/trace_stat.c b/kernel/trace/trace_stat.c
    index cb29282..8669f3c 100644
    --- a/kernel/trace/trace_stat.c
    +++ b/kernel/trace/trace_stat.c
    @@ -73,8 +73,10 @@ int register_stat_tracer(struct tracer_stat *trace)
    /* Already registered? */
    mutex_lock(&all_stat_sessions_mutex);
    list_for_each_entry_safe(node, tmp, &all_stat_sessions, session_list) {
    - if (node->ts == trace)
    + if (node->ts == trace) {
    + mutex_unlock(all_stat_sessions_mutex);
    return -EINVAL;
    + }
    }
    mutex_unlock(&all_stat_sessions_mutex);



    \
     
     \ /
      Last update: 2009-01-15 03:01    [W:0.020 / U:180.000 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site