lkml.org 
[lkml]   [2009]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH -tip] nubus.h: extern's make no sense in userspace
    From
    Date
    On Tue, 2009-01-13 at 10:03 +0100, Geert Uytterhoeven wrote:
    > On Tue, 13 Jan 2009, Jaswinder Singh Rajput wrote:
    > > Impact: cleanup, Impact: fix 3 make headers_check warnings:
    > >
    > > usr/include/linux/nubus.h:298: extern's make no sense in userspace
    > > usr/include/linux/nubus.h:300: extern's make no sense in userspace
    > > usr/include/linux/nubus.h:304: extern's make no sense in userspace
    > >
    > > Also moved nubus_scan_bus() in __KERNEL__
    > >
    > > Also removed obsolete get_nubus_list()
    > >
    > > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
    > > ---
    > > include/linux/nubus.h | 3 ++-
    > > 1 files changed, 2 insertions(+), 1 deletions(-)
    > >
    > > diff --git a/include/linux/nubus.h b/include/linux/nubus.h
    > > index bd31554..9f54a23 100644
    > > --- a/include/linux/nubus.h
    > > +++ b/include/linux/nubus.h
    > > @@ -297,6 +297,7 @@ struct nubus_dev {
    > > struct nubus_board* board;
    > > };
    > >
    > > +#ifdef __KERNEL__
    > > /* This is all NuBus devices (used to find devices later on) */
    > > extern struct nubus_dev* nubus_devices;
    > > /* This is all NuBus cards */
    > > @@ -305,7 +306,7 @@ extern struct nubus_board* nubus_boards;
    > > /* Generic NuBus interface functions, modelled after the PCI interface */
    > > void nubus_scan_bus(void);
    > > extern void nubus_proc_init(void);
    > > -int get_nubus_list(char *buf);
    > > +#endif /* __KERNEL__ */
    > > int nubus_proc_attach_device(struct nubus_dev *dev);
    > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    > > int nubus_proc_detach_device(struct nubus_dev *dev);
    > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    > > /* If we need more precision we can add some more of these */
    >
    > What about these? They (unfortunately) lack the "extern" keyword, but they're
    > still external declarations, and "make headers_check' doesn't notice them?
    >
    > BTW, is there a way to tell gcc to warn about externs not marked "extern", so
    > we can fix all of them?

    I had a look at this file, there's the small patch that just wraps the whole
    section of function declarations with ifdef __KERNEL, or the larger patch
    that does the wrapping _and_ adds the missing externs to make it obvious.

    But I'm not sure that there is agreement regarding adding the externs too.

    What do people think?

    Harvey



    \
     
     \ /
      Last update: 2009-01-14 21:07    [W:0.022 / U:29.564 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site