lkml.org 
[lkml]   [2009]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 7/9] ide: move ->rqsize init from init_irq() to ide_init_port()
Date
On Sunday 11 January 2009, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> >
>
> > Index: b/drivers/ide/ide-probe.c
> > ===================================================================
> > --- a/drivers/ide/ide-probe.c
> > +++ b/drivers/ide/ide-probe.c
> >
> [...]
> > @@ -1242,6 +1234,13 @@ static void ide_init_port(ide_hwif_t *hw
> >
> > if (d->max_sectors)
> > hwif->rqsize = d->max_sectors;
> > + else {
> > + if ((hwif->host_flags & IDE_HFLAG_NO_LBA48) ||
> > + (hwif->host_flags & IDE_HFLAG_NO_LBA48_DMA))
> >
>
> Er, why not:
>
> if (hwif->host_flags &
> (IDE_HFLAG_NO_LBA48 | IDE_HFLAG_NO_LBA48_DMA))

IMO it is harder to read


\
 
 \ /
  Last update: 2009-01-14 18:27    [W:3.053 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site