Messages in this thread | | | Date | Wed, 14 Jan 2009 21:29:35 +0530 | Subject | Re: [PULL -tip] fixed few make headers_check warnings | From | Jaswinder Singh Rajput <> |
| |
Hello Sam,
On Wed, Jan 14, 2009 at 9:08 PM, Sam Ravnborg <sam@ravnborg.org> wrote: >> >
> > I appreciate your work but I will like to question the approach.
My approach was: "PATCH should solve a problem per file", like: capability.h: extern's make no sense in userspace coda_psdev.h: extern's make no sense in userspace in6.h: extern's make no sense in userspace nubus.h: extern's make no sense in userspace socket.h: extern's make no sense in userspace
But this warnings was in many files: include of <linux/types.h> is preferred over <asm/types.h> : 15 files found __[us]{8,16,32,64} type without #include <linux/types.h> : 52 files
So in place of making 15 + 52 = 67 patches, I made 2 patches for each warning.
> We should rather take the warnings as an indication that this > file needs to be looked over and fix not only the warnings > reported but rater to fix all the questionable issues on a file-by-file basis.
Should I make 67 patches ?
-- JSR
| |