| Date | Wed, 14 Jan 2009 16:22:16 +0100 | From | Joerg Roedel <> | Subject | Re: [PATCH 07/16] dma-debug: add debugfs interface |
| |
On Sun, Jan 11, 2009 at 12:08:26AM +0100, Ingo Molnar wrote: > > * Joerg Roedel <joerg.roedel@amd.com> wrote: > > > +/* Global error count */ > > +static u32 error_count; > > + > > +/* Global error show enable*/ > > +static u32 show_all_errors __read_mostly; > > +/* Number of errors to show */ > > +static u32 show_num_errors = 1; > > + > > static u32 num_free_entries; > > static u32 min_free_entries; > > Small detail: please use native C types for non-hardware variables - > 'unsigned int', 'unsigned long', etc. > > u32/u64 is typically used for variables where there is a real significance > to the precise width of the variable: there's either a hardware or a > user-space ABI involved.
There is some kind of userspace ABI: all these variables are exported via debugfs. And debugfs relies on these types.
Joerg
-- | Advanced Micro Devices GmbH Operating | Karl-Hammerschmidt-Str. 34, 85609 Dornach bei München System | Research | Geschäftsführer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München | Registergericht München, HRB Nr. 43632
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|