lkml.org 
[lkml]   [2009]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [RFC][PATCH 4/4] cgroup-memcg fix frequent EBUSY at rmdir
    From
    On Thu, Jan 8, 2009 at 1:35 AM, KAMEZAWA Hiroyuki
    <kamezawa.hiroyu@jp.fujitsu.com> wrote:
    > + if (ret == -EAGAIN) { /* subsys asks us to retry later */
    > + mutex_unlock(&cgroup_mutex);
    > + cond_resched();
    > + goto retry;
    > + }

    This spinning worries me a bit. It might be better to do an
    interruptible sleep until the relevant CSS's refcount goes down to
    zero. And is there no way that the memory controller can hang on to a
    reference indefinitely, if the cgroup still has some pages charged to
    it?

    Paul


    \
     
     \ /
      Last update: 2009-01-14 03:51    [W:0.024 / U:62.716 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site