lkml.org 
[lkml]   [2009]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip] x86: headers - include linux/types.h instead of asm/types.h
[Cyrill Gorcunov - Tue, Jan 13, 2009 at 05:49:56PM +0300]
| [Ingo Molnar - Tue, Jan 13, 2009 at 03:45:05PM +0100]
| ...
| | >
| | > Until such a file not passed to some *.S. For example for e820.h we have
| | > it included to arch/x86/boot/header.S but fortunately we're bound by
| | > __ASSEMBLY__. So there linux/types.h shouldn't hurt. Will check others
| | > and report then.
| |
| | Any reason to not protect types.h with #ifndef __ASSEMBLY__ ?
| |
| | Ingo
| |
|
| hmm... good question :) letme check
|
| - Cyrill -

Dunno Ingo, it's dubious. I don't like the idea
to start including types.h into any kind of *.S
with #ifndef __ASSEMBLY__ protection. We export it
into user space and I don't remember if it mentioned
somewhere that user is not allowed to use -D__ASSEMBLY__.

Someone more experienced (then me) in this area should
asked first :-)

- Cyrill -


\
 
 \ /
  Last update: 2009-01-13 16:09    [W:0.533 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site