Messages in this thread | | | Date | Tue, 13 Jan 2009 18:06:51 +0300 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH -tip] x86: headers - include linux/types.h instead of asm/types.h |
| |
[Cyrill Gorcunov - Tue, Jan 13, 2009 at 05:49:56PM +0300] | [Ingo Molnar - Tue, Jan 13, 2009 at 03:45:05PM +0100] | ... | | > | | > Until such a file not passed to some *.S. For example for e820.h we have | | > it included to arch/x86/boot/header.S but fortunately we're bound by | | > __ASSEMBLY__. So there linux/types.h shouldn't hurt. Will check others | | > and report then. | | | | Any reason to not protect types.h with #ifndef __ASSEMBLY__ ? | | | | Ingo | | | | hmm... good question :) letme check | | - Cyrill -
Dunno Ingo, it's dubious. I don't like the idea to start including types.h into any kind of *.S with #ifndef __ASSEMBLY__ protection. We export it into user space and I don't remember if it mentioned somewhere that user is not allowed to use -D__ASSEMBLY__.
Someone more experienced (then me) in this area should asked first :-)
- Cyrill -
| |