lkml.org 
[lkml]   [2009]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [Regression] USB wakeup problem on Toshiba Portege R500
Date
On Monday 12 January 2009, Alan Stern wrote:
> On Fri, 9 Jan 2009, Rafael J. Wysocki wrote:
>
> > > My proposal:
> > >
> > > Devices and events that are clearly associated with system
> > > wakeup should be enabled by default. For example: Power
> > > button and laptop lid.
> >
> > Agreed.
> >
> > > All other devices capable of waking up the system should be
> > > disabled by default. This presumably includes every PCI
> > > device. If users want keyboard or mouse events to cause
> > > a system resume then they will have to configure their
> > > desktop management program to enable it.
> >
> > I generally agree, with one exception. There are network adapters which
> > can be enabled to wake up by the BIOS and their drivers set them up for WoL
> > currently on this basis. These should remain enabled IMO.
>
> How do we know which adapters these are? IMO the PCI core should
> disable wakeup by default for all devices when they are detected.

This is what we do.

> Is it sufficient to have the adapter drivers enable wakeup during
> their probe routines?

Yes, it is.

Thanks,
Rafael


\
 
 \ /
  Last update: 2009-01-13 00:01    [W:0.108 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site