lkml.org 
[lkml]   [2009]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH] move xilinx_spi's probe function to .devinit.text
    A pointer to xilinx_spi_probe is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    ---
    drivers/spi/xilinx_spi.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/spi/xilinx_spi.c b/drivers/spi/xilinx_spi.c
    index 68d6f49..a5ca137 100644
    --- a/drivers/spi/xilinx_spi.c
    +++ b/drivers/spi/xilinx_spi.c
    @@ -304,7 +304,7 @@ static irqreturn_t xilinx_spi_irq(int irq, void *dev_id)
    return IRQ_HANDLED;
    }

    -static int __init xilinx_spi_probe(struct platform_device *dev)
    +static int __devinit xilinx_spi_probe(struct platform_device *dev)
    {
    int ret = 0;
    struct spi_master *master;
    --
    1.5.6.5
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-01-12 23:53    [W:0.022 / U:33.404 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site