Messages in this thread | | | Date | Tue, 13 Jan 2009 00:42:29 +0300 | From | Evgeniy Polyakov <> | Subject | Re: Linux killed Kenny, bastard! |
| |
On Mon, Jan 12, 2009 at 04:29:10PM -0500, Chris Snook (csnook@redhat.com) wrote: > >Modulo the fact that it does not work for the quickly created processes > >which do not have their oom scores adjusted before the oom. > > cgroups solve this problem much more cleanly.
When they are configured and enabled :) And actually not, since having two separate groups still may result in the wrong oom-killing, the same group should contain all potentially 'bad' processes, so that it could be triggered first and not the whole scan.
Having a name to kill is way too simpler than anything else, and while this may be not the finest grain solution, it is what is the most obvious and the simplest to work with.
I do agree, that there are ways to solve the same problem, and likely they provide better control, but setup/control cost is uncomparable with simple name-based scheme to select 'victim' processes by their scores.
Effectively it is similar to oom_kill_allocating_task trick, which also can be solved by adjusting oom-score for every other process in the system or by putting it into the separate group, or anything else. But still it is much simpler to have a single flag which solves the problem maybe not optimally, but close to it in the most cases.
The same does my patch, which allows to select a set of processes by the given string in the executable name, and then get a victim among them based on the existing scores. This is the simplest and thus it could be the most useful case.
-- Evgeniy Polyakov
| |