lkml.org 
[lkml]   [2009]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: checkpatch warning of struct indentation
2009/1/12 Steven Rostedt <rostedt@goodmis.org>:
>
> Hi,
>
> I'm now seeing the following warnings from checkpatch:
>
> #325: FILE: kernel/trace/trace_stat.c:21:
> + void *stat;
>
> ERROR: "foo *bar" should be "foo *bar"
> #334: FILE: kernel/trace/trace_stat.c:27:
> + struct tracer_stat *ts;
>
> ERROR: "foo *bar" should be "foo *bar"
> #337: FILE: kernel/trace/trace_stat.c:30:
> + struct dentry *file;


Oh my patch :-)
Yeah I had the same errors when I checked it. I ignored them because
I because I remembered checkpatch.pl didn't warn about such things before.
And it seems to warn about such statements since very recently...


> This is for:
>
> struct tracer_stat_session {
> struct list_head session_list;
> struct tracer_stat *ts;
> struct list_head stat_list;
> struct mutex stat_mutex;
> struct dentry *file;
> };
>
> Which looks a hell of a lot better than:
>
> struct tracer_stat_session {
> struct list_head session_list;
> struct tracer_stat *ts;
> struct list_head stat_list;
> struct mutex stat_mutex;
> struct dentry *file;
> };
>
> We probably do not want to warn on such things.
>
> -- Steve
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>


\
 
 \ /
  Last update: 2009-01-12 19:11    [from the cache]
©2003-2011 Jasper Spaans