lkml.org 
[lkml]   [2009]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ext4: fix unhandled ext4_free_data allocation failure
On Sun, Jan 11, 2009 at 10:58:35PM -0500, Theodore Tso wrote:
> On Sun, Jan 11, 2009 at 08:46:32AM -0600, Eric Sandeen wrote:
> >
> > Well, this will now force a filesystem error (then remount-ro or panic
> > (or ignore) if the allocation fails. I'm not sure that's better...?
> >
>
> Well, our choices basically are:
>
> 1) Force a filesystem error
> 2) Sleep and retry the allocation
> 3) Don't add the freed blocks to the list regions that mballoc should
> be allowed to allocate from after the transaction commits. This
> results in the blocks getting "leaked" until the filesystem is
> mounted/unounted.

I just thought of another alternative:

4) Mark the buddy cache has being in need of being completely rebuilt
after the transaction commits.

Someone want to try coding that up?

- Ted


\
 
 \ /
  Last update: 2009-01-12 16:07    [W:0.048 / U:1.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site