lkml.org 
[lkml]   [2009]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/6] checkpatch: struct seq_operations should normally be const
    Date
    In the general use case struct seq_operations should be a const object.
    Check for and warn where it is not.

    Cc: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: Andy Whitcroft <apw@canonical.com>
    ---
    scripts/checkpatch.pl | 7 ++++---
    1 files changed, 4 insertions(+), 3 deletions(-)

    diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    index 5ea55e3..447435c 100755
    --- a/scripts/checkpatch.pl
    +++ b/scripts/checkpatch.pl
    @@ -2527,9 +2527,10 @@ sub process {
    WARN("please use device_initcall() instead of __initcall()\n" . $herecurr);
    }
    # check for struct file_operations, ensure they are const.
    - if ($line =~ /\bstruct\s+file_operations\b/ &&
    - $line !~ /\bconst\b/) {
    - WARN("struct file_operations should normally be const\n" . $herecurr);
    + if ($line !~ /\bconst\b/ &&
    + $line =~ /\bstruct\s+(file_operations|seq_operations)\b/) {
    + WARN("struct $1 should normally be const\n" .
    + $herecurr);
    }

    # use of NR_CPUS is usually wrong
    --
    1.6.0.4.911.gc990


    \
     
     \ /
      Last update: 2009-01-12 13:49    [W:0.018 / U:30.128 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site