lkml.org 
[lkml]   [2009]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 3/4] net: pppol2tp - introduce net-namespace functionality
Cyrill Gorcunov wrote:
> - Each tunnel and appropriate lock are inside own namespace now.
> - pppox code allows to create per-namespace sockets for
> both PX_PROTO_OE and PX_PROTO_OL2TP protocols. Actually since
> now pppox_create support net-namespaces new PPPo... protocols
> (if they ever will be) should support net-namespace too otherwise
> explicit check for &init_net would be needed.
>
> CC: James Chapman <jchapman@katalix.com>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> ---
> drivers/net/pppol2tp.c | 164 ++++++++++++++++++++++++++++++++++++-------------
> drivers/net/pppox.c | 4 -
> 2 files changed, 121 insertions(+), 47 deletions(-)

Looks ok from a pppol2tp point of view, though I'm not an expert on the
netns stuff.

The patches don't apply against latest net-next-2.6. If you respin the
patches, I'll test them for pppol2tp.

--
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development



\
 
 \ /
  Last update: 2009-01-10 12:17    [W:0.072 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site