lkml.org 
[lkml]   [2009]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] swiotlb: range_needs_mapping should take a physical address.
From
On Fri,  9 Jan 2009 18:32:09 +0000
Ian Campbell <Ian.Campbell@citrix.com> wrote:
> The swiotlb_arch_range_needs_mapping() hook should take a physical
> address rather than a virtual address in order to support highmem pages.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> ---
> arch/x86/kernel/pci-swiotlb_64.c | 2 +-
> include/linux/swiotlb.h | 2 +-
> lib/swiotlb.c | 10 +++++-----
> 3 files changed, 7 insertions(+), 7 deletions(-)

Yeah, using a cpu address here doesn't make sense. I wondered what you
were trying with a cpu address when reading your original patch.

Might be more clean to unify address_needs_mapping and
range_needs_mapping. I guess that I need to see what Xen wants to do
with this though.



\
 
 \ /
  Last update: 2009-01-11 05:01    [from the cache]
©2003-2011 Jasper Spaans