lkml.org 
[lkml]   [2009]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 15/16] dma-debug: x86 architecture bindings

* Joerg Roedel <joerg.roedel@amd.com> wrote:

> @@ -105,6 +109,7 @@ dma_unmap_single(struct device *dev, dma_addr_t addr, size_t size,
> struct dma_mapping_ops *ops = get_dma_ops(dev);
>
> BUG_ON(!valid_dma_direction(direction));
> + debug_unmap_single(dev, addr, size, direction);

It all looks very nice, i've got one small namespace structure request:
could you please name all the callbacks in a consistent way, so that they
mirror the method they instrument - with a "debug_" prefix?

I.e. the above one would be: debug_dma_unmap_single().

Ingo


\
 
 \ /
  Last update: 2009-01-11 00:09    [W:0.276 / U:1.316 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site