Messages in this thread Patch in this message | | | Date | Tue, 9 Sep 2008 09:19:16 +0200 | From | Ingo Molnar <> | Subject | Re: [git pull] x86 fixes |
| |
* Ingo Molnar <mingo@elte.hu> wrote:
> > * David Sanders <linux@sandersweb.net> wrote: > > > On Monday 08 September 2008 17:43, H. Peter Anvin wrote: > > > Does this patch fix that for you? > > > > > > > Yes, thanks. > > it fixes build errors in my test setup too.
Sam, i've applied Peter's fix (see the commit below) - do you have any objections to us carrying this in x86/urgent? It's needed for the gcc fix/workaround.
Ingo
---------------> From 095fbc7296ccfe41688e8ef136587b23f0e8c123 Mon Sep 17 00:00:00 2001 From: H. Peter Anvin <hpa@zytor.com> Date: Mon, 8 Sep 2008 14:43:11 -0700 Subject: [PATCH] kbuild: fix cc-option and cc-option-yn
David Sanders wrote:
> I'm getting this error: > as: unrecognized option `-mtune=generic32' > I have binutils 2.17.
Use -c instead of -S in cc-option and cc-option-yn, so we can probe options related to the assembler.
Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: kbuild devel <kbuild-devel@lists.sourceforge.net> Signed-off-by: Ingo Molnar <mingo@elte.hu> --- scripts/Kbuild.include | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include index d64e6ba..982dcae 100644 --- a/scripts/Kbuild.include +++ b/scripts/Kbuild.include @@ -105,12 +105,12 @@ as-instr = $(call try-run,\ # Usage: cflags-y += $(call cc-option,-march=winchip-c6,-march=i586) cc-option = $(call try-run,\ - $(CC) $(KBUILD_CFLAGS) $(1) -S -xc /dev/null -o "$$TMP",$(1),$(2)) + $(CC) $(KBUILD_CFLAGS) $(1) -c -xc /dev/null -o "$$TMP",$(1),$(2)) # cc-option-yn # Usage: flag := $(call cc-option-yn,-march=winchip-c6) cc-option-yn = $(call try-run,\ - $(CC) $(KBUILD_CFLAGS) $(1) -S -xc /dev/null -o "$$TMP",y,n) + $(CC) $(KBUILD_CFLAGS) $(1) -c -xc /dev/null -o "$$TMP",y,n) # cc-option-align # Prefix align with either -falign or -malign
| |