lkml.org 
[lkml]   [2008]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Xen: Fix pte unpin BUG when !CONFIG_SMP
    Jeremy Fitzhardinge wrote:
    > Alex Nixon wrote:
    >
    >>
    >> Here's the backtrace of the BUG() the patch addresses. Now you've
    >> pointed it out - I see the asymmetry - and also suspect some ptes are
    >> being left pinned.
    >>
    >> I'm having trouble finding a cleaner solution which solves this but
    >> doesn't incite more BUGs.
    >> Perhaps you have an idea?
    >>
    >
    > Right, I see. We shouldn't be pinning ptes on attachment in
    > xen_alloc_ptpage() if we're not using split pte locks.
    >
    > J
    >
    >
    Hmm ok. I'll search further for a solution which fixes things more
    officially (and deals with the CONFIG_SMP && (NR_CPUS <
    CONFIG_SPLIT_PTLOCK_CPUS) case, which I just realized is also broken,
    and isn't fixed by this patch).

    In the meantime, at least UP is now usable.

    - Alex


    \
     
     \ /
      Last update: 2008-09-10 00:29    [W:0.028 / U:119.592 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site