[lkml]   [2008]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC 09/13] genapic: reduce stack pressuge in io_apic.c step 1 temp cpumask_ts
Mike Travis <> writes:

> * Step 1 of cleaning up io_apic.c removes local cpumask_t variables
> from the stack.

Sorry that patch seems incredibly messy. Global variables
and a tricky ordering and while it's at least commented it's still a mess
and maintenance unfriendly.

Also I think set_affinity is the only case where a truly arbitary cpu
mask can be passed in anyways. And it's passed in from elsewhere.

The other cases generally just want to handle a subset of CPUs which
are nearby. How about you define a new cpumask like type that
consists of a start/stop CPU and a mask for that range only
and is not larger than a few words?

I think with that the nearby assignments could be handled
reasonably cleanly with arguments and local variables.

And I suspect with some restructuring set_affinity could
be also made to support such a model.


 \ /
  Last update: 2008-09-08 13:03    [W:0.136 / U:3.964 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site