Messages in this thread | | | Date | Mon, 8 Sep 2008 15:05:53 -0700 | From | "Paul Menage" <> | Subject | Re: [PATCH] cgroup(fix critical bug): new handling for tasks file |
| |
On Mon, Sep 8, 2008 at 2:16 PM, Andrew Morton <akpm@linux-foundation.org> wrote: > On Thu, 04 Sep 2008 22:34:47 -0700 > Paul Menage <menage@google.com> wrote: > >> npids = cgroup_task_count(cgrp); >> + pidarray = kmalloc(npids * sizeof(pid_t), GFP_KERNEL); > > kmalloc becomes more unreliable above 32 kbytes and 100% unreliable > above MAX_ORDER.
Agreed, but that's something to be fixed in a different patch - the existing cgroups code (and cpusets originally) has had this kind of kmalloc call in it.
I think it should be reasonably straightforward to replace it with an array of page allocations.
Paul
| |