Messages in this thread | | | Date | Mon, 08 Sep 2008 16:30:38 +0100 | From | "Jan Beulich" <> | Subject | Re: [PATCH] x86: x86_{phys,virt}_bits field also for i386 (v2) |
| |
>> c->x86_virt_bits = (eax >> 8) & 0xff; >> c->x86_phys_bits = eax & 0xff; >> + /* CPUID workaround for Intel 0F33/0F34 CPU */ >> + if (c->x86_vendor == X86_VENDOR_INTEL >> + && c->x86 == 0xF && c->x86_model == 0x3 >> + && (c->x86_mask == 0x3 >> + || c->x86_mask == 0x4)) >> + c->x86_phys_bits = 36; > >these lines should be in early_init_intel/init_intel. >also need to be checked if it could be overwriten by others functions later..
I think this should then be a follow-up patch.
>BTW, did you address Peter's concern?
Sorry, I don't recall anything else I needed to address.
Jan
| |