lkml.org 
[lkml]   [2008]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 3/3] x86: io-apic - code style cleaning for setup_IO_APIC_irqs

* Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> here is an another attempt to satisfy the requirements :)
> Please review and comment if it looks better or worse now.

sigh, i think the extra buffering is clearly worse. These are early init
printks and we already do many other cases of multi-line printouts and
even KERN_CONT printouts. We have a perfectly fine built-in buffer
already: the printk buffer.

Ingo


\
 
 \ /
  Last update: 2008-09-07 17:49    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog