lkml.org 
[lkml]   [2008]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] MMC: Use write timeout value as read from CSR
On Mon, 1 Sep 2008 16:12:03 +0100
"Matt Fleming" <mattjfleming@googlemail.com> wrote:

> Currently, the MMC/SD over SPI code has a hard-coded timeout value of
> 250ms on writes. This is correct for SD cards and is specified in the
> spec, but it is not correct for MMC cards. For MMC cards the values
> that is read from the CSR should be used.
>
> There is already code to ensure that the write timeout value for SD
> cards does not exceed 250ms, this patch only affects the MMC case.
>

This actually isn't fully correct for SD either as it only specifies
that 250 ms is the upper bound on the timeout.

I believe the proper way of solving this is to have mmc_spi respect the
timeouts set in the request structure. Modify mmc_set_data_timeout() if
necessary.

Rgds
--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org

WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.


\
 
 \ /
  Last update: 2008-09-07 12:41    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog