lkml.org 
[lkml]   [2008]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kernel/cpu.c: Move the CPU_DYING notifiers

* Manfred Spraul <manfred@colorfullife.com> wrote:

> Ingo Molnar wrote:
>> * Manfred Spraul <manfred@colorfullife.com> wrote:
>>
>>> - raw_notifier_call_chain(&cpu_chain, CPU_DYING | param->mod,
>>> - param->hcpu);
>>> /* Ensure this CPU doesn't handle any more interrupts. */
>>> err = __cpu_disable();
>>> if (err < 0)
>>> return err;
>>> + raw_notifier_call_chain(&cpu_chain, CPU_DYING | param->mod,
>>> + param->hcpu);
>>>
>>
>> hm, doesnt this break things like CPU cross-calls done in CPU_DYING
>> callbacks?
>>
>
> We are within stop_machine(). No other cpu is running. As fas as I can
> see no cross-calls are possible.

ah, ok - my bad. I was confusing it with the much more common
CPU_DOWN_PREPARE type of callbacks which do use various cross-CPU APIs.

applied to tip/sched/devel, thanks Manfred!

Ingo


\
 
 \ /
  Last update: 2008-09-06 19:17    [W:0.031 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site