Messages in this thread | | | Date | Sat, 6 Sep 2008 18:01:37 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCHSET 0/5] BUILD_BUG_ON: error on none-const expressions |
| |
* Boaz Harrosh <bharrosh@panasas.com> wrote:
> Submitted a patchset to fix BUILD_BUG_ON to no longer let through > none compile-time constant expressions. This was debated a few > times on LKML. The final solution is as proposed by Rusty Russell, > which produces all expected results in my tests. > [see: http://www.spinics.net/lists/kernel/msg772904.html] > > [PATCH 1/5] debug, x86: move BUILD_BUG_ON() ARRAY_SIZE and __FUNCTION__ > Ingo this is your patch. Please verify?
yeah.
Acked-by: Ingo Molnar <mingo@elte.hu>
> [PATCH 5/5] debug: BUILD_BUG_ON: error on none-const expressions > Finally after all call sites are fixed this can go in. > (Rusty this one is From: you)
v3 looks good to me.
Andrew, are you picking this up? Looks like the perfect fit for -mm to me. I can drop the previous version from -tip so that there's no linux-next conflict.
Ingo
| |