[lkml]   [2008]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC patch 0/4] TSC calibration improvements

On Sat, 6 Sep 2008, Thomas Gleixner wrote:
> If Alok has the second check in place and is actually worried about
> that 288us impact, then we can add the following (untested), which
> does not impact the speed of the check.

Guys, please.

Show some _taste_.

Dammit, stop adding random crap to "native_calibrate_tsc()" and make it
look like total and utter SHIT.

If you want to do that

tsc1 = tsc_read_refs(&ref1, hpet);
tsc2 = tsc_read_refs(&ref1, hpet);

around calibration and comparing it, then do it *once*. Do it over the
whole thing. Do it in a function of its own, instead of making this
horrible and unreadable mess.

This patch may be fine as a "let's check if it works" thing, but please
don't send out total SH*T to public lists.

Some _tasted_ in programming, please!


 \ /
  Last update: 2008-09-06 23:01    [W:0.080 / U:33.016 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site