lkml.org 
[lkml]   [2008]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC patch 0/4] TSC calibration improvements


On Sat, 6 Sep 2008, Linus Torvalds wrote:

>
>
> On Sat, 6 Sep 2008, Thomas Gleixner wrote:
> >
> > Just checked. The -tip version still has the expect-- in the for()
> > which might lead to stupid results depending on the gcc madness level.
>
> Umm. What? You're on some odd drugs.

Oh, you mean te "--expect" in the last pit_expect_msb(). Yeah, that one
looks bogus, but I don't understand what it has to do with gcc at all.

"expect" is an unsigned char. There are absolutely _zero_ issues with
overflow, underflow, random phases of the moon, madness levels or anything
else. But yes, it does look like Ingo screwed up when adding that final
check, since expect was already decremented at the end of the loop.

Ingo? Did you actually test it?

Linus


\
 
 \ /
  Last update: 2008-09-06 22:57    [W:0.078 / U:6.484 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site