Messages in this thread | | | Date | Sat, 6 Sep 2008 20:49:14 +0200 | From | Ingo Molnar <> | Subject | Re: [patch 3/3] x86: io-apic - code style cleaning for setup_IO_APIC_irqs |
| |
* Maciej W. Rozycki <macro@linux-mips.org> wrote:
> On Sat, 6 Sep 2008, Cyrill Gorcunov wrote: > > > Ingo, how about the following approach? We don't introduce new > > functions but rather srink the code by new printout form. > > Honestly, this one should probably use sprintf() or suchlike to avoid the > mess of printk() calls building a line of output from pieces. It's quite > easy to calculate here what the maximum size of the buffer required could > be and automatic arrays can have variable size, so no need for the hassle > of heap management. Calls to printk() without a trailing newline should > be avoided where possible as it messes up logging priority if a message > pops up from an interrupt inbetween.
hm, is it worth the trouble? This is during very early init.
Ingo
| |