lkml.org 
[lkml]   [2008]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASYNC_TX: fix the bug in async_tx_run_dependencies
Hello,

Dan Williams wrote:
> Please also take a look at this cleanup patch that I will queue for
> .28. I think it makes things easier to read let me know if you
> disagree.
>

Look good for me. Hmm, actually I don't think that current version is so
hard to read...

Just one comment:

> - if (!next)
> + if (dep)
> + chan = dep->chan;
> + else
> return;
>

I don't like 'return' inside 'else'.

Regards, Ilya.



\
 
 \ /
  Last update: 2008-09-05 12:21    [W:0.030 / U:6.844 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site