Messages in this thread | | | Date | Fri, 05 Sep 2008 14:17:22 +0400 | From | Ilya Yanok <> | Subject | Re: [PATCH] ASYNC_TX: fix the bug in async_tx_run_dependencies |
| |
Hello,
Dan Williams wrote: > Please also take a look at this cleanup patch that I will queue for > .28. I think it makes things easier to read let me know if you > disagree. >
Look good for me. Hmm, actually I don't think that current version is so hard to read...
Just one comment:
> - if (!next) > + if (dep) > + chan = dep->chan; > + else > return; >
I don't like 'return' inside 'else'.
Regards, Ilya.
| |