[lkml]   [2008]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [alsa-devel] [PATCH 2/9] ASoC: Blackfin: SPORT peripheral interface driver
On Fri, Sep 05, 2008 at 06:21:35PM +0800, Bryan Wu wrote:

> + /* Maybe the dummy buffer descriptor ring is damaged */
> + sport->dummy_rx_desc->next_desc_addr = \
> + (unsigned long)(sport->dummy_rx_desc+1);

Here and elsewhere in this driver you've got continuation characters
which aren't need. I've fixed this up locally (and some additional
checkpatch/coding standards things) here and in other patches in the

Otherwise the patch series looks good to go, thanks - I'm just about to
review the codec driver patch that it depends upon.

 \ /
  Last update: 2008-09-05 15:13    [W:0.054 / U:0.504 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site