Messages in this thread | | | Date | Thu, 4 Sep 2008 11:17:29 -0500 | From | "Serge E. Hallyn" <> | Subject | Re: unprivileged mounts git tree |
| |
Quoting Miklos Szeredi (miklos@szeredi.hu): > On Thu, 04 Sep 2008, Miklos Szeredi wrote: > > On Thu, 4 Sep 2008, Serge E. Hallyn wrote: > > > Are you going to revert the change forcing CL_SLAVE for > > > !capable(CAP_SYS_ADMIN)? I don't think we want that - I think that > > > *within* a set of user mounts, propagation should be safe, right? > > > > > > Will you be able to do this soon? If not, should we just do the part > > > returning -EPERM when turning a shared mount into a user mount? > > > > OK, let's do that first and the tricky part (propagation vs. user > > mounts) later. Will push after I've tested it. > > Here it is: > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git unprivileged-mounts
but you're still doing
if (IS_MNT_SHARED(old_nd.path.mnt) && !capable(CAP_SYS_ADMIN)) goto out;
shouldn't it be something like
if (IS_MNT_SHARED(old_nd.path.mnt) && (old_nd.path.mnt & MNT_USER)) goto out;
?
> I don't know what's next, this patchset has been in and out of -mm for > as long as I can remember, but it hasn't generated much interest > outside the two of us :) > > I do think this is an important feature though, even if not as sexy as > some other things. > > Al? Is there any chance of this making it to 2.6.28? > > Thanks, > Miklos
| |