lkml.org 
[lkml]   [2008]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Revert commit e8aa4667baf74dfd85fbaab86861465acb811085
On Thu, 4 Sep 2008, Ingo Molnar wrote:

>
> * Andreas Herrmann <andreas.herrmann3@amd.com> wrote:
>
> > This reverts commit e8aa4667baf74dfd85fbaab86861465acb811085
> > (x86: enable hpet=force for AMD SB400)
> >
> > Since ATI/AMD decided not to support HPET on SB4xx it doesn't
> > make sense to enable this unsupported feature.
> > (I was not aware of this when submitting the quirk.)
> >
> > If a system with SB4xx chipset provides an ACPI HPET table and does
> > not boot, "nohpet" should be used as kernel parameter.
> >
> > Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
>
> applied to tip/x86/urgent, thanks Andreas. I guess a system broke due to
> this commit?

Hmm, why do we remove something which needs to be force enabled by the
user anyway ?

Is the HPET on these systems not working at all so the force enable
code is useless ?

Thanks,

tglx


\
 
 \ /
  Last update: 2008-09-04 18:17    [from the cache]
©2003-2011 Jasper Spaans