lkml.org 
[lkml]   [2008]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] dw_dmac: Fix copy/paste bug in tasklet
    Date
    The tasklet checks RAW.BLOCK twice, and does not check RAW.XFER. This is
    obviously wrong, and could theoretically cause the driver to hang.

    Reported-by: Nicolas Ferre <nicolas.ferre@atmel.com>
    Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
    ---
    drivers/dma/dw_dmac.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
    index 94df917..0778d99 100644
    --- a/drivers/dma/dw_dmac.c
    +++ b/drivers/dma/dw_dmac.c
    @@ -364,7 +364,7 @@ static void dw_dma_tasklet(unsigned long data)
    int i;

    status_block = dma_readl(dw, RAW.BLOCK);
    - status_xfer = dma_readl(dw, RAW.BLOCK);
    + status_xfer = dma_readl(dw, RAW.XFER);
    status_err = dma_readl(dw, RAW.ERROR);

    dev_vdbg(dw->dma.dev, "tasklet: status_block=%x status_err=%x\n",
    --
    1.5.6.5


    \
     
     \ /
      Last update: 2008-09-30 16:31    [W:0.022 / U:30.952 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site