Messages in this thread | | | Date | Tue, 30 Sep 2008 13:27:28 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 0/2] x86: split out dumpstack code from traps_xx.c |
| |
* Alexander van Heukelum <heukelum@fastmail.fm> wrote:
> Hi Ingo, > > I intend to keep looking for possibilities to bring traps_32.c and > traps_64.c closer to each-other. One trivial way (from my point of > view) is to split out code into separate files. These two patches > split out a large piece of code that has nothing to do with hardware > traps. Are you willing to take those two patches? Or are they to > intrusive?
they are not intrusive at all! The right way to do such things is to keep them in reasonably small files.
> Patches are against the current master branch of the tip tree. The > defconfigs compile fine and I ran some simple configs within qemu.
would be nice to bring dumpstack_32.c and dumpstack_64.c together as well. While some of the details like IST stack logic (which dont exist on 32-bit) are special, most of the glue, the iterators, the boot parameters, and even the output should be unified some more.
Ingo
| |