lkml.org 
[lkml]   [2008]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 12/13] hrtimer: create a "timer_slack" field in the task struct
Date
Hi Arjan, 

Sorry for _really_ late responce.
I recently found this patch in linux-next.

In general, I like this patch.
However,

> + case PR_SET_TIMERSLACK:
> + if (arg2 <= 0)
> + current->timer_slack_ns =
> + current->default_timer_slack_ns;
> + else
> + current->timer_slack_ns = arg2;
> + break;
> default:
> error = -EINVAL;
> break;

I wonder to why PR_SET_TIMERSLACK decreasing doesn't need root privilege.

example,
nice() systemcall is
- nice increasing (pirority decreasing) doesn't need root privilege.
- nice decreasing (priority incriasing) need root privilege.

So, I think time slack setting need similar one.
Otherwise, non-privilege user can increase power consumpsion easily by PR_SET_TIMERSLACK.

What do you think?




\
 
 \ /
  Last update: 2008-09-30 07:19    [W:0.304 / U:0.936 seconds]
©2003-2014 Jasper Spaans. hosted at Digital Ocean