lkml.org 
[lkml]   [2008]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix TSC calibration issues
Linus Torvalds wrote:
>
> On Tue, 2 Sep 2008, Larry Finger wrote:
>> I know that Linus has some problems with this patch, but FWIW it worked on my
>> K6. The dmesg output is
>>
>> TSC: PIT calibration deviates from PMTIMER: 428809 214401.
>> TSC: Using PIT calibration value
>> Detected 428.809 MHz processor.
>
> I don't have a problem with what the patch _does_ (I think all the added
> sanity checking is good).
>
> I just don't like how it makes the already rather complex and confusing
> function about ten times _more_ complex and confusing. It needs splitting
> up.
>
> But we can split it up after-the-fact as well as before-the-fact.
>
> Does this cleanup-patch (on _top_ of Thomas' patch) also work for you? It
> should do exactly the same thing, except it splits up the TSC PIT
> calibration into a function of its own.
>
> But I may obviously have introduced some silly bug when cleaning it up,
> so testing necessary..

Same result as Thomas' version.

Larry



\
 
 \ /
  Last update: 2008-09-03 06:37    [W:0.086 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site